lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 21 Mar 2017 19:30:20 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Prasant Jalan <prasant.jalan@...il.com>
Cc:     forest@...ttletooquiet.net, arushisinghal19971997@...il.com,
        devel@...verdev.osuosl.org, elise.lennion@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: vt6656: fxed coding style errors

On Tue, Mar 21, 2017 at 10:25:40PM +0530, Prasant Jalan wrote:
> This patch replaces spaces with tabs for indentation as per kernel
> coding standards.
> 
> Signed-off-by: Prasant Jalan <prasant.jalan@...il.com>
> ---
>  drivers/staging/vt6656/rf.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
> index 068c1c8..f69bced 100644
> --- a/drivers/staging/vt6656/rf.c
> +++ b/drivers/staging/vt6656/rf.c
> @@ -876,7 +876,7 @@ void vnt_rf_table_download(struct vnt_private *priv)
>  	memcpy(array, addr1, length1);
>  
>  	vnt_control_out(priv, MESSAGE_TYPE_WRITE, 0,
> -		        MESSAGE_REQUEST_RF_INIT, length1, array);
> +			MESSAGE_REQUEST_RF_INIT, length1, array);
>  
>  	/* Channel Table 0 */
>  	value = 0;
> @@ -889,7 +889,7 @@ void vnt_rf_table_download(struct vnt_private *priv)
>  		memcpy(array, addr2, length);
>  
>  		vnt_control_out(priv, MESSAGE_TYPE_WRITE,
> -			        value, MESSAGE_REQUEST_RF_CH0, length, array);
> +				value, MESSAGE_REQUEST_RF_CH0, length, array);
>  
>  		length2 -= length;
>  		value += length;
> @@ -907,7 +907,7 @@ void vnt_rf_table_download(struct vnt_private *priv)
>  		memcpy(array, addr3, length);
>  
>  		vnt_control_out(priv, MESSAGE_TYPE_WRITE,
> -			        value, MESSAGE_REQUEST_RF_CH1, length, array);
> +				value, MESSAGE_REQUEST_RF_CH1, length, array);
>  
>  		length3 -= length;
>  		value += length;
> @@ -924,7 +924,7 @@ void vnt_rf_table_download(struct vnt_private *priv)
>  
>  		/* Init Table 2 */
>  		vnt_control_out(priv, MESSAGE_TYPE_WRITE,
> -			        0, MESSAGE_REQUEST_RF_INIT2, length1, array);
> +				0, MESSAGE_REQUEST_RF_INIT2, length1, array);
>  
>  		/* Channel Table 0 */
>  		value = 0;
> @@ -937,7 +937,7 @@ void vnt_rf_table_download(struct vnt_private *priv)
>  			memcpy(array, addr2, length);
>  
>  			vnt_control_out(priv, MESSAGE_TYPE_WRITE,
> -				        value, MESSAGE_REQUEST_RF_CH2, length, array);
> +				value, MESSAGE_REQUEST_RF_CH2, length, array);

Why make this last change?  It's now not indented properly :(

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ