linux-kernel - Re: [PATCH] arm64: dts: hi6220: enable DMA in spi0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAj6DX3kvc-wy+xSPBC26Xw0s6BBApTJQGrVS1BsiFgfDybBbw@mail.gmail.com>
Date:   Tue, 21 Mar 2017 20:13:29 +0100
From:   Antonio Borneo <borneo.antonio@...il.com>
To:     Guodong Xu <guodong.xu@...aro.org>
Cc:     xuwei5@...ilicon.com, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Wang Xiaoyin <hw.wangxiaoyin@...ilicon.com>,
        Zhong Kaihua <zhongkaihua@...wei.com>,
        linux-spi@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: hi6220: enable DMA in spi0

On Tue, Mar 21, 2017 at 8:08 AM, Guodong Xu <guodong.xu@...aro.org> wrote:
> From: Wang Xiaoyin <hw.wangxiaoyin@...ilicon.com>
>
> Enable DMA in spi0.

Hi Guodong, Xiaoyin,

added linux-spi in copy.

Actually the patch does not enable the DMA. The commit message is not correct.

> Cc: Antonio Borneo <borneo.antonio@...il.com>
> Signed-off-by: Zhong Kaihua <zhongkaihua@...wei.com>
> Signed-off-by: Guodong Xu <guodong.xu@...aro.org>
> Signed-off-by: Wang Xiaoyin <hw.wangxiaoyin@...ilicon.com>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 470461d..e40625f 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -682,7 +682,8 @@
>                         reg = <0x0 0xf7106000 0x0 0x1000>;
>                         interrupts = <0 50 4>;
>                         bus-id = <0>;
> -                       enable-dma = <0>;
> +                       dmas =  <&dma0 0 &dma0 1>;
> +                       dma-names = "rx", "tx";

The controller spi0 is a standard ARM PL022.
This patch removes the nonexistent property "enable-dma" and specifies
which DMA controller and which DMA channels are connected to spi0.
The values are coherent with the documentation available for hi6220.

Apart from the commit message, I'm fine with this patch.

On PL022 the DMA is not enabled in the DT node of the controller but
in the DT node of each spi device, through the property
"pl022,com-mode".
A separate patch should eventually enable the DMA for those spi
devices that require it.

Best Regards,
Antonio

>                         clocks = <&sys_ctrl HI6220_SPI_CLK>;
>                         clock-names = "apb_pclk";
>                         pinctrl-names = "default";
> --
> 2.10.2
>