linux-kernel - Re: [PATCH v3 4/4] arm64: dts: rockchip: add regulator info for Kevin digitizer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20415662.PctC9IM4SC@phil>
Date:   Wed, 22 Mar 2017 09:26:41 +0100
From:   Heiko Stuebner <heiko@...ech.de>
To:     Brian Norris <briannorris@...omium.org>
Cc:     linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Caesar Wang <wxt@...k-chips.com>,
        Doug Anderson <dianders@...omium.org>,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Stephen Barber <smbarber@...omium.org>,
        linux-arm-kernel@...ts.infradead.org,
        Chris Zhong <zyw@...k-chips.com>
Subject: Re: [PATCH v3 4/4] arm64: dts: rockchip: add regulator info for Kevin digitizer

Am Montag, 20. März 2017, 16:53:44 CET schrieb Brian Norris:
> We need to enable this regulator before the digitizer can be used. Wacom
> recommended waiting for 100 ms before talking to the HID.
> 
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> ---
> v3:
>  * reintroduced into patch set; bindings are in linux-next
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts index
> 2f720cf2fd07..f4714c4606f3 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> @@ -232,6 +232,9 @@ ap_i2c_dig: &i2c2 {

according to the hid-over-i2c binding, this should use a special compatible 
like

	compatible = "wacom,w9013", "hid-over-i2c"

As the binding patch is from Caesar, I assume that is the Kevin component and
I can add that myself, just need confirmation that this is actually the correct 
component :-) .


Thanks
Heiko

>  		pinctrl-names = "default";
>  		pinctrl-0 = <&cpu1_dig_irq_l &cpu1_dig_pdct_l>;
> 
> +		vdd-supply = <&p3_3v_dig>;
> +		post-power-on-delay-ms = <100>;
> +
>  		interrupt-parent = <&gpio2>;
>  		interrupts = <4 IRQ_TYPE_LEVEL_LOW>;