linux-kernel - Re: [PATCH] usb: gadget: Correct usb EP argument for BOT status request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87var1u0k1.fsf@linux.intel.com>
Date:   Wed, 22 Mar 2017 11:23:58 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     "Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
        Manish Narani <manish.narani@...inx.com>
Cc:     gregkh@...uxfoundation.org, xypron.glpk@....de, mnarani@...inx.com,
        bart.vanassche@...disk.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, anirudh@...inx.com,
        svemula@...inx.com, target-devel <target-devel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: Correct usb EP argument for BOT status request


Hi,

"Nicholas A. Bellinger" <nab@...ux-iscsi.org> writes:
> Hi Manish,
>
> (Added target-devel CC')
>
> On Mon, 2017-03-20 at 15:05 +0530, Manish Narani wrote:
>> This patch corrects the argument in usb_ep_free_request as it is
>> mistakenly set to ep_out. It should be ep_in for status request.
>> 
>> Signed-off-by: Manish Narani <mnarani@...inx.com>
>> ---
>>  drivers/usb/gadget/function/f_tcm.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
>> index d235113..a82e2bd 100644
>> --- a/drivers/usb/gadget/function/f_tcm.c
>> +++ b/drivers/usb/gadget/function/f_tcm.c
>> @@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)
>>  	usb_ep_free_request(fu->ep_in, fu->bot_req_in);
>>  	usb_ep_free_request(fu->ep_out, fu->bot_req_out);
>>  	usb_ep_free_request(fu->ep_out, fu->cmd.req);
>> -	usb_ep_free_request(fu->ep_out, fu->bot_status.req);
>> +	usb_ep_free_request(fu->ep_in, fu->bot_status.req);
>>  
>>  	kfree(fu->cmd.buf);
>>  
>
> Applied to target-pending/master.

Oh, so you're taking patches for f_tcm? Fair enough:

Acked-by: Felipe Balbi <felipe.balbi@...ux.intel.com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)