linux-kernel - Re: [PATCH 1/5] clk: meson: Add support for parameters for specific PLLs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8dbb772-90c9-b98f-d237-4b773188faf5@baylibre.com>
Date:   Wed, 22 Mar 2017 11:23:24 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Michael Turquette <mturquette@...libre.com>, sboyd@...eaurora.org,
        carlo@...one.org, khilman@...libre.com
Cc:     linux-clk@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] clk: meson: Add support for parameters for specific
 PLLs

On 03/22/2017 12:43 AM, Michael Turquette wrote:
> Quoting Neil Armstrong (2017-03-13 06:26:40)
[..]
>>  
>>         p = &pll->n;
>> -       ret = meson_clk_pll_wait_lock(pll, p);
>> +       /* If unreset_for_lock is provided, remove the reset bit here */
>> +       if (pll->params.unreset_for_lock) {
> 
> Small nitpick, but I find "unreset" to be confusing. Since 'reset' here
> is a bit that can be set and unset, maybe use clear_reset_for_lock
> instead?
> 
> Regards,
> Mike
> 

You are right, I'll rename it.

Neil