linux-kernel - Re: [PATCH] drm/msm/hdmi: redefinitions of macros not required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF6AEGtjUtxz+n0xsyYtVtQfb0=homN_t4mjzFS=ezjBQ2ugmw@mail.gmail.com>
Date:   Wed, 22 Mar 2017 07:19:10 -0400
From:   Rob Clark <robdclark@...il.com>
To:     Vinay Simha B N <simhavcs@...il.com>
Cc:     David Airlie <airlied@...ux.ie>,
        "open list:DRM DRIVER FOR MSM ADRENO GPU" 
        <linux-arm-msm@...r.kernel.org>,
        "open list:DRM DRIVER FOR MSM ADRENO GPU" 
        <dri-devel@...ts.freedesktop.org>,
        "open list:DRM DRIVER FOR MSM ADRENO GPU" 
        <freedreno@...ts.freedesktop.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm/hdmi: redefinitions of macros not required

On Wed, Mar 22, 2017 at 1:11 AM, Vinay Simha B N <simhavcs@...il.com> wrote:
> hi,
>
> Could you please give some feedback or review comments for this patch

looks good, I've pulled it into msm-next

BR,
-R

> On 3/14/17, Vinay Simha BN <simhavcs@...il.com> wrote:
>> 4 macros already defined in hdmi.h,
>> which is not required to redefine in hdmi_audio.c
>>
>> Signed-off-by: Vinay Simha BN <simhavcs@...il.com>
>> ---
>>  drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 -------
>>  1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
>> b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
>> index a54d3bb..8177e85 100644
>> --- a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
>> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
>> @@ -18,13 +18,6 @@
>>  #include <linux/hdmi.h>
>>  #include "hdmi.h"
>>
>> -
>> -/* Supported HDMI Audio channels */
>> -#define MSM_HDMI_AUDIO_CHANNEL_2             0
>> -#define MSM_HDMI_AUDIO_CHANNEL_4             1
>> -#define MSM_HDMI_AUDIO_CHANNEL_6             2
>> -#define MSM_HDMI_AUDIO_CHANNEL_8             3
>> -
>>  /* maps MSM_HDMI_AUDIO_CHANNEL_n consts used by audio driver to # of
>> channels: */
>>  static int nchannels[] = { 2, 4, 6, 8 };
>>
>> --
>> 2.7.4
>>
>>
>
>
> --
> regards,
> vinaysimha