linux-kernel - Re: [PATCH 1/5] x86: Implement _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170322141823.2ilzsmfeghe3ra4j@treble>
Date:   Wed, 22 Mar 2017 09:18:23 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     mingo@...nel.org, tglx@...utronix.de, hpa@...or.com,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        arjan@...ux.intel.com, bp@...en8.de, richard.weinberger@...il.com
Subject: Re: [PATCH 1/5] x86: Implement __WARN using UD0

On Wed, Mar 22, 2017 at 09:47:06AM +0100, Peter Zijlstra wrote:
> 
> A little like so then.
> 
> ---
> Subject: x86: Implement __WARN using UD0
> From: Peter Zijlstra <peterz@...radead.org>
> Date: Thu Feb 2 14:43:51 CET 2017
> 
> By using "UD0" for WARNs we remove the function call and its possible
> __FILE__ and __LINE__ immediate arguments from the instruction stream.
> 
> Total image size will not change much, what we win in the instruction
> stream we'll loose because of the __bug_table entries. Still, saves on
> I$ footprint and the total image size does go down a bit.
> 
>    text    data     bss     dec     hex filename
> 10702123        4530992  843776 16076891         f5505b defconfig-build/vmlinux.0
> 10682460        4530992  843776 16057228         f5038c defconfig-build/vmlinux.1
> 
> (um didn't seem to use GENERIC_BUG at all, so remove it)
> 
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Richard Weinberger <richard.weinberger@...il.com>
> Cc: Arjan van de Ven <arjan@...ux.intel.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Josh Poimboeuf <jpoimboe@...hat.com>
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>

Looks good, thanks!

Reviewed-by: Josh Poimboeuf <jpoimboe@...hat.com>

-- 
Josh