linux-kernel - Re: [PATCH v1 3/5] ARM: dts: stm32ap: Add watchdog support for STM32F429 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <70b47d08-9628-f0c6-094f-c3712527bda8@st.com>
Date:   Wed, 22 Mar 2017 14:50:20 +0100
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Yannick Fertre <yannick.fertre@...com>,
        Wim Van Sebroeck <wim@...ana.be>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh+dt@...nel.org>,
        Benjamin Gaignard <benjamin.gaignard@...com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
CC:     <linux-watchdog@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Philippe Cornu <philippe.cornu@...com>,
        Gabriel FERNANDEZ <gabriel.fernandez@...com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v1 3/5] ARM: dts: stm32ap: Add watchdog support for
 STM32F429 SoC

Hi

On 03/22/2017 02:36 PM, Yannick Fertre wrote:
> Signed-off-by: Yannick FERTRE <yannick.fertre@...com>
> ---

Please add a commit message, and change commit header as following:

ARM: dts: stm32: ...

>  arch/arm/boot/dts/stm32f429.dtsi | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
> index ee0da97..148273b 100644
> --- a/arch/arm/boot/dts/stm32f429.dtsi
> +++ b/arch/arm/boot/dts/stm32f429.dtsi
> @@ -65,7 +65,7 @@
>  			clock-frequency = <32768>;
>  		};
>
> -		clk-lsi {
> +		clk_lsi: clk-lsi {
>  			#clock-cells = <0>;
>  			compatible = "fixed-clock";
>  			clock-frequency = <32000>;
> @@ -812,6 +812,13 @@
>  			clocks = <&rcc 0 STM32F4_AHB2_CLOCK(RNG)>;
>
>  		};
> +
> +		iwdg: iwdg@...03000 {
Please try to keep nodes ordered.

> +			compatible = "st,stm32-iwdg";
> +			reg = <0x40003000 0x400>;
> +			clocks = <&clk_lsi>;
> +			status = "disabled";
> +		};
>  	};
>  };
>
>