linux-kernel - Re: [PATCH] sched/fair: Fix ftq noise bench regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d5ec252-9d83-93ef-0d56-27895e8d388d@arm.com>
Date:   Wed, 22 Mar 2017 17:22:45 +0000
From:   Dietmar Eggemann <dietmar.eggemann@....com>
To:     Vincent Guittot <vincent.guittot@...aro.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "Huang, Ying" <ying.huang@...el.com>
Subject: Re: [PATCH] sched/fair: Fix ftq noise bench regression

On 22/03/17 16:55, Vincent Guittot wrote:
> On 22 March 2017 at 17:22, Dietmar Eggemann <dietmar.eggemann@....com> wrote:
>> On 22/03/17 09:22, Vincent Guittot wrote:
>>> On 21 March 2017 at 18:46, Dietmar Eggemann <dietmar.eggemann@....com> wrote:
>>>> Hi Vincent,
>>>>
>>>> On 17/03/17 13:47, Vincent Guittot wrote:

[...]

>> +static inline bool blocked_update_needed(struct sched_entity *se)
>> +{
>> +       struct cfs_rq *gcfs_rq = group_cfs_rq(se);
> 
> gcfs_rq can't be set before testing that se is not null

Ah correct, but you could set it after the !se check.