linux-kernel - Re: [PATCH net-next 1/8] ptr_ring: introduce batch dequeuing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <590abb0f-e28a-52f7-5abc-b72159e31d5f@redhat.com>
Date:   Wed, 22 Mar 2017 11:16:07 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        mst@...hat.com, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/8] ptr_ring: introduce batch dequeuing



On 2017年03月21日 18:25, Sergei Shtylyov wrote:
> Hello!
>
> On 3/21/2017 7:04 AM, Jason Wang wrote:
>
>> Signed-off-by: Jason Wang <jasowang@...hat.com>
>> ---
>>  include/linux/ptr_ring.h | 65 
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 65 insertions(+)
>>
>> diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
>> index 6c70444..4771ded 100644
>> --- a/include/linux/ptr_ring.h
>> +++ b/include/linux/ptr_ring.h
>> @@ -247,6 +247,22 @@ static inline void *__ptr_ring_consume(struct 
>> ptr_ring *r)
>>      return ptr;
>>  }
>>
>> +static inline int __ptr_ring_consume_batched(struct ptr_ring *r,
>> +                         void **array, int n)
>> +{
>> +    void *ptr;
>> +    int i = 0;
>> +
>> +    while (i < n) {
>
>    Hm, why not *for*?

Yes, it maybe better, if there's other comment on the series, will 
change it in next version.

Thanks