linux-kernel - Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21d6cfe5-3263-4eeb-c35b-c75f34185526@ti.com>
Date:   Wed, 22 Mar 2017 13:30:12 -0500
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Julia Cartwright <julia@...com>
CC:     Lionel Debieve <lionel.debieve@...com>,
        <linux-rt-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <bigeasy@...utronix.de>, <tglx@...utronix.de>
Subject: Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic


On 03/22/2017 01:01 PM, Steven Rostedt wrote:
> On Wed, 22 Mar 2017 12:37:59 -0500
> Julia Cartwright <julia@...com> wrote:
>
>> Which kernel were you testing on, here?  From what I can tell, this
>> should have been fixed with Thomas's commit:
>>
>>    2a1d3ab8986d ("genirq: Handle force threading of irqs with primary
>> and thread handler")
>
> Thanks Julia for looking into this. I just looked at the code, and saw
> that it does very little with the lock held, and was fine with the
> conversion. But if that interrupt handler should be in a thread, we
> should see if that's the issue first.


It will not be threaded because there are IRQF_ONESHOT used.

	ret = devm_request_threaded_irq(&pdev->dev, irq,
					sti_mbox_irq_handler,
					sti_mbox_thread_handler,
					IRQF_ONESHOT, mdev->name, mdev);

>
>>
>> Which landed in 4.4.  It forces the primary handler to be threaded as
>> well.
>>
>
> Lionel,
>
> Can you check if this is an issue with 4.4 too?
>


-- 
regards,
-grygorii