linux-kernel - Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170322184749.GC2899@dtor-ws>
Date:   Wed, 22 Mar 2017 11:47:49 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Jagan Teki <jagan@...rulasolutions.com>
Cc:     Jagan Teki <jagan@...nedev.com>, linux-input@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Matteo Lisi <matteo.lisi@...icam.com>,
        Michael Trimarchi <michael@...rulasolutions.com>
Subject: Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table

On Wed, Mar 22, 2017 at 11:44:21AM -0700, Dmitry Torokhov wrote:
> On Thu, Mar 23, 2017 at 12:05:17AM +0530, Jagan Teki wrote:
> > On Thu, Mar 23, 2017 at 12:00 AM, Dmitry Torokhov
> > <dmitry.torokhov@...il.com> wrote:
> > > On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote:
> > >> From: Jagan Teki <jagan@...rulasolutions.com>
> > >>
> > >> Added missing of_match_table for max11801_ts driver with
> > >> compatible as "maxim,max11801_ts"
> > >>
> > >
> > > Why not "maxim,max11801"? Also, I think we'd need a binding document.
> > 
> > Compatibility purpose to make this is for touchscreen and few of other
> 
> Compatibility with what? The i2c id is "max11801" (without the "-ts").

Now that I looked at your 2/3 and 3/3 patches you use:

+&i2c1 {
+       max11801: touchscreen@48 {
+               compatible = "maxim,max11801";
+               reg = <0x48>;
+               interrupt-parent = <&gpio3>;
+               interrupts = <31 2>;
+       };
+};

so the compatible you are adding to the driver is definitely wrong.

By the way, it would be nice if you used symbolic constants to express
interrupt trigger type.

Thanks.

-- 
Dmitry