linux-kernel - Re: [PATCH v7] staging: adis16060_core: Replace mlock with buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b8ee8a9-c147-64ad-bcf9-c126f21145fc@kernel.org>
Date:   Wed, 22 Mar 2017 20:14:07 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     kbuild test robot <lkp@...el.com>,
        simran singhal <singhalsimran0@...il.com>
Cc:     kbuild-all@...org, lars@...afoo.de, devel@...verdev.osuosl.org,
        Michael.Hennerich@...log.com, linux-iio@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Hartmut Knaack <knaack.h@....de>
Subject: Re: [PATCH v7] staging: adis16060_core: Replace mlock with buf_lock
 and refactor code

On 22/03/17 20:00, kbuild test robot wrote:
> Hi simran,
> 
> [auto build test WARNING on iio/togreg]
> [also build test WARNING on v4.11-rc3 next-20170322]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/simran-singhal/staging-adis16060_core-Replace-mlock-with-buf_lock-and-refactor-code/20170323-031726
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> config: x86_64-randconfig-s0-03230201 (attached as .config)
> compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/staging/iio/gyro/adis16060_core.c: In function 'adis16060_read_raw':
>>> drivers/staging/iio/gyro/adis16060_core.c:79: warning: unused variable 'st'
Already fixed in V8 which has been applied to the togreg branch of iio.git.

Thanks,
Jonathan
> 
> vim +/st +79 drivers/staging/iio/gyro/adis16060_core.c
> 
>     63		if (!ret)
>     64			*val = ((st->buf[0] & 0x3) << 12) |
>     65				 (st->buf[1] << 4) |
>     66				 ((st->buf[2] >> 4) & 0xF);
>     67		mutex_unlock(&st->buf_lock);
>     68	
>     69		return ret;
>     70	}
>     71	
>     72	static int adis16060_read_raw(struct iio_dev *indio_dev,
>     73				      struct iio_chan_spec const *chan,
>     74				      int *val, int *val2,
>     75				      long mask)
>     76	{
>     77		u16 tval = 0;
>     78		int ret;
>   > 79		struct adis16060_state *st = iio_priv(indio_dev);
>     80	
>     81		switch (mask) {
>     82		case IIO_CHAN_INFO_RAW:
>     83			ret = adis16060_spi_write_than_read(indio_dev,
>     84							    chan->address, &tval);
>     85			if (ret < 0)
>     86				return ret;
>     87	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>