linux-kernel - Re: [PATCH] drivers/staging/dgnc: Updating dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170323072323.GA1283@kroah.com>
Date:   Thu, 23 Mar 2017 08:23:23 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pushkar Jambhlekar <pushkar.iit@...il.com>
Cc:     Lidza Louina <lidza.louina@...il.com>,
        Mark Hounschell <markh@...pro.net>,
        driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/staging/dgnc: Updating dev_dbg function

On Wed, Mar 22, 2017 at 01:17:57PM +0530, Pushkar Jambhlekar wrote:
> Making use of __func__ instead of using function name directly in dev_dbg.
> 
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@...il.com>
> ---
>  drivers/staging/dgnc/dgnc_tty.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index f7e754e..b0c88b8 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -1858,13 +1858,13 @@ static void dgnc_tty_send_xchar(struct tty_struct *tty, char c)
>  	if (!bd || bd->magic != DGNC_BOARD_MAGIC)
>  		return;
>  
> -	dev_dbg(tty->dev, "dgnc_tty_send_xchar start\n");
> +	dev_dbg(tty->dev, "%s start\n", __func__);

As I stated on the mailing list a few days ago, these lines need to just
be deleted entirely, as we have ftrace to help with this type of thing.

thanks,

greg k-h