linux-kernel - Re: [PATCH] sched: Prefer sibiling only if local group is under-utilized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170323074201.qufsm2h6hvndrfdy@hirez.programming.kicks-ass.net>
Date:   Thu, 23 Mar 2017 08:42:01 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Mike Galbraith <efault@....de>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched: Prefer sibiling only if local group is
 under-utilized

On Wed, Mar 22, 2017 at 11:27:50PM +0530, Srikar Dronamraju wrote:

> @@ -7536,8 +7537,8 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd
>  		 * the tasks on the system).
>  		 */
>  		if (prefer_sibling && sds->local &&
> -		    group_has_capacity(env, &sds->local_stat) &&
> -		    (sgs->sum_nr_running > 1)) {
> +		    group_has_capacity(env, local) &&
> +		    (sgs->sum_nr_running > local->sum_nr_running + 1)) {
>  			sgs->group_no_capacity = 1;
>  			sgs->group_type = group_classify(sg, sgs);
>  		}

Ah, yes that makes sense!

Thanks