linux-kernel - Re: [PATCH] checkpatch: Allow space leading blank lines in email headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1490250520.2041.22.camel@perches.com>
Date:   Wed, 22 Mar 2017 23:28:40 -0700
From:   Joe Perches <joe@...ches.com>
To:     Darren Hart <dvhart@...radead.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Andy Whitcroft <apw@...onical.com>,
        John 'Warthog9' Hawley <warthog9@...lescrag.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Allow space leading blank lines in email
 headers

On Wed, 2017-03-22 at 23:20 -0700, Darren Hart wrote:
> I do have an open question regarding how we're going about testing for the end
> of the header lines. Since we're not just testing for an empty line to separate
> headers and body, there is clearly more going on here - but I'm not sure what it
> is ... so I can't be sure this doesn't have an unintended consequence.
> 
> > +		      $rawline =~ /^(?:commit\b|from\b|[\w-]+:)/i)) {
> 
> This appears to be an unrelated change, introducing the non-capturing-group
> (?:) and dropping the superfluous .*$ postfix. Did I get that right?

Exactly right.

The capturing of the initial bit of the match and
testing of the rest of the line is simply unnecessary.

I frequently make localized changes like that when I
notice them.  It's not a problem.

cheers, Joe