linux-kernel - Re: [PATCH 1/1] mmc: core: export emmc revision via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+yUs=yJtjpFENQuz55AEjEHtR3GQ=zm-=MHnTyS45JGTPEkLA@mail.gmail.com>
Date:   Wed, 22 Mar 2017 17:23:57 -0700
From:   Jin Qian <jinqian@...roid.com>
To:     Jaehoon Chung <jh80.chung@...sung.com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Uri Yanai <uri.yanai@...disk.com>,
        Dong Aisheng <aisheng.dong@....com>,
        Chaotian Jing <chaotian.jing@...iatek.com>,
        Pratibhasagar V <pratibha@...eaurora.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] mmc: core: export emmc revision via sysfs

Removed redundant signoff.

export rev to collect some statistics on how many devices are running
with which mmc revision.

Other attr name seems follow cid.<name> or ext_csd.<name>.

Thanks,
jin


On Tue, Mar 21, 2017 at 3:17 PM, Jaehoon Chung <jh80.chung@...sung.com> wrote:
> Hi,
>
> On 03/22/2017 07:01 AM, Jin Qian wrote:
>> Extend sysfs to access ext_csd revision information.
>>
>> Signed-off-by: Jin Qian <jinqian@...gle.com>
>> Signed-off-by: Jin Qian <jinqian@...roid.com>
>
> I think you can choose one of them for signed-off tag.
>
>> ---
>>  drivers/mmc/core/mmc.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
>> index 7fd722868875..08c62c9bec48 100644
>> --- a/drivers/mmc/core/mmc.c
>> +++ b/drivers/mmc/core/mmc.c
>> @@ -779,6 +779,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid);
>>  MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name);
>>  MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid);
>>  MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv);
>> +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev);
>
> I'm not sure but if someone want to know ext_csd revision information, attribute name might be more clearly.
> e,g) ext_csd_rev?
>
> It's my preference. :)
>
> Best Regards,
> Jaehoon Chung
>
>>  MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info);
>>  MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n",
>>       card->ext_csd.device_life_time_est_typ_a,
>> @@ -836,6 +837,7 @@ static struct attribute *mmc_std_attrs[] = {
>>       &dev_attr_name.attr,
>>       &dev_attr_oemid.attr,
>>       &dev_attr_prv.attr,
>> +     &dev_attr_rev.attr,
>>       &dev_attr_pre_eol_info.attr,
>>       &dev_attr_life_time.attr,
>>       &dev_attr_serial.attr,
>>
>