linux-kernel - [PATCH] drivers/staging/dgnc: Removing manual function tracing using dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1490259053-3245-1-git-send-email-pushkar.iit@gmail.com>
Date:   Thu, 23 Mar 2017 14:20:53 +0530
From:   Pushkar Jambhlekar <pushkar.iit@...il.com>
To:     Lidza Louina <lidza.louina@...il.com>,
        Mark Hounschell <markh@...pro.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org,
        Pushkar Jambhlekar <pushkar.iit@...il.com>
Subject: [PATCH] drivers/staging/dgnc: Removing manual function tracing using dev_dbg

Current implementation manually traces function using 'dev_dbg'. This way is not needed because of ftrace, making these calls redundant.

Signed-off-by: Pushkar Jambhlekar <pushkar.iit@...il.com>
---
 drivers/staging/dgnc/dgnc_tty.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f7e754e..cae0410 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -1858,13 +1858,9 @@ static void dgnc_tty_send_xchar(struct tty_struct *tty, char c)
 	if (!bd || bd->magic != DGNC_BOARD_MAGIC)
 		return;
 
-	dev_dbg(tty->dev, "dgnc_tty_send_xchar start\n");
-
 	spin_lock_irqsave(&ch->ch_lock, flags);
 	bd->bd_ops->send_immediate_char(ch, c);
 	spin_unlock_irqrestore(&ch->ch_lock, flags);
-
-	dev_dbg(tty->dev, "dgnc_tty_send_xchar finish\n");
 }
 
 /* Return modem signals to ld. */
-- 
2.7.4