linux-kernel - Re: [PATCH] ARM: gemini: don't select SERIAL_OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYfi2_Tu+RD+s=xR8pHkp0bQ96pB4BSJdA1bO4kdwku5Q@mail.gmail.com>
Date:   Thu, 23 Mar 2017 11:22:54 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann <arnd@...db.de> wrote:

> We cannot select the option when SERIAL_8250 is not also set:
>
> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF)
>
> This removes the 'select' statement, requiring that users enable the
> option manually. Alternatively, we could make it a conditional
> 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful
> of other symbols that it depends on.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Will you apply this directly to the interestingly misspelled
"gemeni/multiplatform" branch in the ARM SoC tree
directly?

I will send pull requests on top of that branch later
for more features.

Yours,
Linus Walleij