linux-kernel - Re: [PATCHv2 2/2] leds: cpcap: new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Mar 2017 02:04:43 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc:     Tony Lindgren <tony@...mide.com>,
        Richard Purdie <rpurdie@...ys.net>,
        Pavel Machek <pavel@....cz>, Lee Jones <lee.jones@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 2/2] leds: cpcap: new driver

Hi Jacek,

On Wed, Mar 22, 2017 at 09:24:35PM +0100, Jacek Anaszewski wrote:
> > +#define CPCAP_LED_OFF 0x0000
> > +#define CPCAP_LED_ON 0x01
> 
> In this case you can do very well without CPCAP_LED_OFF and
> CPCAP_LED_ON, since we have both counterparts in the core:
> LED_OFF and LED_ON.

I will use them in PATCHv3.

> > +static const struct of_device_id cpcap_led_of_match[] = {
> > +	{ .compatible = "motorola,cpcap-led-red", .data = &cpcap_led_red },
> 
> checkpatch.pl complains here:
> 
> WARNING: DT compatible string vendor "motorola" appears un-documented
> 
> Are you adding vendor prefix in some other patch?

Yes, the vendor prefix is added in rtc-next [0].

Since it's just a checkpatch warning and fixed in linux-next I
suggest to ignore it instead of bothering with an immutable branch.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=0522de00929e9e9ee51235fc40035179e4d45381

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)