linux-kernel - Re: [PATCH] ARM: nommu: access ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170323104310.GA6941@afzalpc>
Date:   Thu, 23 Mar 2017 16:13:10 +0530
From:   afzal mohammed <afzal.mohd.ma@...il.com>
To:     Russell King - ARM Linux <linux@...linux.org.uk>,
        Greg Ungerer <gerg@...inux.org>
Cc:     Vladimir Murzin <vladimir.murzin@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: nommu: access ID_PFR1 only if CPUID scheme

Hi,

On Fri, Mar 17, 2017 at 10:10:34PM +0530, afzal mohammed wrote:
> Greg upon trying to boot no-MMU Kernel on ARM926EJ reported boot
> failure. He root caused it to ID_PFR1 access introduced by the
> commit mentioned in the fixes tag below.
> 
> All CP15 processors need not have processor feature registers, only
> for architectures defined by CPUID scheme would have it. Hence check
> for it before accessing processor feature register, ID_PFR1.
> 
> Fixes: f8300a0b5de0 ("ARM: 8647/2: nommu: dynamic exception base address setting")
> Reported-by: Greg Ungerer <gerg@...inux.org>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@...il.com>

Greg, can i add your Tested-by ?

Regards
afzal

> ---
> 
> Hi Russell,
> 
> It would be good to have the fix go in during -rc, as,
> 
> 1. Culprit commit went in during the last merge window
> 2. Though nothing supported in mainline is known to be broken, the
>     original change needs to be modified to be reliable