linux-kernel - Re: [PATCH] ARM: gemini: don't select SERIAL_OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZ4UWAWnkR7Q9AxVQgbnxB_wkMRNRxT7TDK8Lpm1CfVoQ@mail.gmail.com>
Date:   Thu, 23 Mar 2017 14:01:19 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

On Thu, Mar 23, 2017 at 1:13 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Thu, Mar 23, 2017 at 11:22 AM, Linus Walleij
> <linus.walleij@...aro.org> wrote:
>> On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann <arnd@...db.de> wrote:
>>
>>> We cannot select the option when SERIAL_8250 is not also set:
>>>
>>> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF)
>>>
>>> This removes the 'select' statement, requiring that users enable the
>>> option manually. Alternatively, we could make it a conditional
>>> 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful
>>> of other symbols that it depends on.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>
>> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>>
>> Will you apply this directly to the interestingly misspelled
>> "gemeni/multiplatform" branch in the ARM SoC tree
>> directly?
>>
>> I will send pull requests on top of that branch later
>> for more features.
>
> If you are going to send more pull requests, just add the fixup there,
> it's not urgent.

OK thanks, I'll queue it.

Yours,
Linus Walleij