linux-kernel - Re: [PATCH] EDAC, pnd2_edac: fix build error without CONFIG_EDAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170323152722.bsxfhspximq4cxap@pd.tnic>
Date:   Thu, 23 Mar 2017 16:27:22 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Tony Luck <tony.luck@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Qiuxu Zhuo <qiuxu.zhuo@...el.com>, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC, pnd2_edac: fix build error without
 CONFIG_EDAC_DEBUG

On Thu, Mar 23, 2017 at 04:16:35PM +0100, Arnd Bergmann wrote:
> Calling into functions inside of the #ifdef causes an obvious compile error:
> 
> drivers/edac/pnd2_edac.c: In function 'pnd2_init':
> drivers/edac/pnd2_edac.c:1521:2: error: implicit declaration of function 'setup_pnd2_debug'; did you mean 'setup_log_buf'? [-Werror=implicit-function-declaration]
> drivers/edac/pnd2_edac.c: In function 'pnd2_exit':
> drivers/edac/pnd2_edac.c:1529:2: error: implicit declaration of function 'teardown_pnd2_debug' [-Werror=implicit-function-declaration]
> 
> This removes the #ifdef and instead uses an equivalent IS_ENABLED() check
> so the compiler can silently drop the functions but still build-test them
> and not need an #ifdef.
> 
> Fixes: 5c71ad17f97e ("EDAC, pnd2_edac: Add new EDAC driver for Intel SoC platforms")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/edac/pnd2_edac.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Thanks Arnd, I'm already running randconfig builds on the fixes:

https://lkml.kernel.org/r/20170322172923.GA15888@nazgul.tnic

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.