linux-kernel - Re: [tpmdd-devel] [PATCH] tpm/tpm_crb: fix unused warnings on suspend/resume functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170323155117.w6zsewdxc6eeti4b@intel.com>
Date:   Thu, 23 Mar 2017 17:51:17 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     "Winkler, Tomas" <tomas.winkler@...el.com>
Cc:     Jérémy Lefaure <jeremy.lefaure@....epita.fr>,
        "tpmdd-devel@...ts.sourceforge.net" 
        <tpmdd-devel@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>
Subject: Re: [tpmdd-devel] [PATCH] tpm/tpm_crb: fix unused warnings on
 suspend/resume functions

On Tue, Mar 21, 2017 at 10:05:36PM +0000, Winkler, Tomas wrote:
> > On Thu, Mar 16, 2017 at 09:51:33PM -0400, Jérémy Lefaure wrote:
> > > When PM_SLEEP is disabled crb_pm_suspend and crb_pm_resume are not
> > > used by SET_SYSTEM_SLEEP_PM_OPS even if PM is enabled:
> > >
> > > drvers/char/tpm/tpm_crb.c:540:12: warning: ‘crb_pm_suspend’ defined
> > > but not used [-Wunused-function]  static int crb_pm_suspend(struct
> > > device *dev)
> > >             ^
> > > drivers/char/tpm/tpm_crb.c:551:12: warning: ‘crb_pm_resume’ defined
> > > but not used [-Wunused-function]  static int crb_pm_resume(struct
> > > device *dev)
> > >             ^
> > >
> > > The preprocessor condition should be on CONFIG_PM_SLEEP, not on
> > CONFIG_PM.
> > > However, this patch fixes this warning by using __maybe_unused on
> > > function that are in the preprocessor condition.
> > >
> > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@....epita.fr>
> > 
> > Thanks. Please include also linux-kernel@...r.kernel.org in the future.
> > 
> > Reviewed-by: Jarkko Saskkinen <jarkko.sakkinen@...ux.intel.com>
> 
> We should go with Arnd's patch, which is actually the same,  but it
> was already reviewed and has better commit messages.
> Thanks
> Tomas

You are right about the commit message but where are the Reviewed-by
tags? [1]

[1] https://patchwork.kernel.org/patch/9633537/

/Jarkko