linux-kernel - Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170323172839.jndyzyi23nna6jya@pd.tnic>
Date:   Thu, 23 Mar 2017 18:28:39 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     "Luck, Tony" <tony.luck@...el.com>
Cc:     X86 ML <x86@...nel.org>, linux-edac <linux-edac@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector

On Thu, Mar 23, 2017 at 10:20:31AM -0700, Luck, Tony wrote:
> It can happen if Linux didn't actually take the page offline
> (because it was a kernel page). The CEC code only knows that
> it queued this page to be taken offline ... and has no way
> to know if that succeeded or not.

Right, that's the case when the offlining fails for whatever reason.

> So is it worth keeping track of the page numbers that we
> tried to offline?  If they show up again we shouldn't add
> them back into the array.

Meh, I don't like the idea of keeping an evergrowing list of PFNs we
can't do anything about anyway.

And actually, you want the kernel to keep complaining about not being
able to offline those because then admins should consider speeding up
the arrival of the maintenance window - the kernel memory itself is
going sick so that not even RAS actions help here.

I'm wondering if we should make the offlining code dump a more
comprehensible message with hints what to do...

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.