linux-kernel - Re: [PATCH] arc: vdk: Fix support of UIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2d81e8a-b2d0-0eb0-295a-f91fb58f4563@synopsys.com>
Date:   Thu, 23 Mar 2017 10:37:51 -0700
From:   Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:     Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ruud Derwig <Ruud.Derwig@...opsys.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Jos van Eijndhoven <Jos.vanEijndhoven@...opsys.com>
Subject: Re: [PATCH] arc: vdk: Fix support of UIO

+CC Jos !

-Vineet

On 03/23/2017 10:34 AM, Alexey Brodkin wrote:
> MotherBoard section has its "ranges" set to 0xE000_0000-0xF000_0000.
> But UIO node maps 4 different areas in different memory locations
> and all outside MB's ranges.
>
> That obviously breaks UIO mappings in runtime.
>
> Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com>
> Cc: Vineet Gupta <vgupta@...opsys.com>
> Cc: Ruud Derwig <rderwig@...opsys.com>
> Cc: stable@...r.kernel.org
> ---
>  arch/arc/boot/dts/vdk_axs10x_mb.dtsi | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arc/boot/dts/vdk_axs10x_mb.dtsi b/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
> index f0df59b23e21..459fc656b759 100644
> --- a/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
> +++ b/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
> @@ -112,13 +112,19 @@
>  			interrupts = <7>;
>  			bus-width = <4>;
>  		};
> +	};
>  
> -		/* Embedded Vision subsystem UIO mappings; only relevant for EV VDK */
> -		uio_ev: uio@...0000000 {
> -			compatible = "generic-uio";
> -			reg = <0xD0000000 0x2000 0xD1000000 0x2000 0x90000000 0x10000000 0xC0000000 0x10000000>;
> -			reg-names = "ev_gsa", "ev_ctrl", "ev_shared_mem", "ev_code_mem";
> -			interrupts = <23>;
> -		};
> +	/*
> +	 * Embedded Vision subsystem UIO mappings; only relevant for EV VDK
> +	 *
> +	 * This node is intentionally put outside of MB above becase
> +	 * it maps areas outside of MB's 0xEz-0xFz.
> +	 */
> +	uio_ev: uio@...0000000 {
> +		compatible = "generic-uio";
> +		reg = <0xD0000000 0x2000 0xD1000000 0x2000 0x90000000 0x10000000 0xC0000000 0x10000000>;
> +		reg-names = "ev_gsa", "ev_ctrl", "ev_shared_mem", "ev_code_mem";
> +		interrupt-parent = <&mb_intc>;
> +		interrupts = <23>;
>  	};
>  };