linux-kernel - [PATCH] drivers/misc: Aspeed LPC control fix format string warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20170323042905.10354-1-cyrilbur@gmail.com>
Date:   Thu, 23 Mar 2017 15:29:05 +1100
From:   Cyril Bur <cyrilbur@...il.com>
To:     greg@...ah.com
Cc:     openbmc@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        joel@....id.au, benh@...nel.crashing.org, sfr@...b.auug.org.au,
        linux-next@...r.kernel.org
Subject: [PATCH] drivers/misc: Aspeed LPC control fix format string warning

resource_size_t is a derivative of phys_addr_t and should also be
printed with %pap:
    drivers/misc/aspeed-lpc-ctrl.c:232:17: warning: format '%x' expects
    argument of type 'unsigned int', but argument 4 has type
    'resource_size_t {aka long long unsigned int}' [-Wformat=] dev_info(dev,
    "Loaded at %pap (0x%08x)\n",

Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
Signed-off-by: Cyril Bur <cyrilbur@...il.com>
---
 drivers/misc/aspeed-lpc-ctrl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/aspeed-lpc-ctrl.c b/drivers/misc/aspeed-lpc-ctrl.c
index c654651a7b6d..2f6bb2244be5 100644
--- a/drivers/misc/aspeed-lpc-ctrl.c
+++ b/drivers/misc/aspeed-lpc-ctrl.c
@@ -229,8 +229,8 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev)
 	if (rc)
 		dev_err(dev, "Unable to register device\n");
 	else
-		dev_info(dev, "Loaded at %pap (0x%08x)\n",
-			&lpc_ctrl->mem_base, lpc_ctrl->mem_size);
+		dev_info(dev, "Loaded at %pap (%pap)\n",
+			&lpc_ctrl->mem_base, &lpc_ctrl->mem_size);
 
 	return rc;
 }
-- 
2.12.1