linux-kernel - [PATCH 0/5] inofify: Reduce lock contention on read()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170324213638.9114-1-jsorensen@fb.com>
Date:   Fri, 24 Mar 2017 17:36:33 -0400
From:   Jes Sorensen <jes.sorensen@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     john@...nmccutchan.com, rlove@...ve.org, eparis@...isplace.org,
        josef@...icpanda.com, kernel-team@...com,
        Jes Sorensen <jsorensen@...com>
Subject: [PATCH 0/5] inofify: Reduce lock contention on read()

Hi,

Running inotify on a very large number hierachy of directories and
files can result in major lock contention between the producer and
consumer of events.

The current code takes the spinlock when pulling each event off the
queue, which isn't overly idea. This patchset reduces the lock
contention by splicing off the event queue while processing reads and
putting the leftover events back on the queue once the read buffer is
full. In order to ensure ordering when reading events, a mutex is
added to read().

While this should reduce the number of locks taken on read when
reading in bulk, it does increase the overhead for the case where the
users tries to read one event at a time.

Last, the first patch of the series adds the missing mutex_destoy()
for mark_mutex.

Thoughts?
Jes

Jes Sorensen (5):
  notify: Call mutex_destroy() before freeing mutex memory
  inotify: Use mutex to prevent threaded clients reading events out of
    order
  notify: Split up some fsnotify functions
  inotify: switch get_one_event() to use fsnotify_list_*() helpers
  inotify: Avoid taking spinlock for each event processed in read()

 fs/notify/group.c                    |  1 +
 fs/notify/inotify/inotify_fsnotify.c |  1 +
 fs/notify/inotify/inotify_user.c     | 42 ++++++++++++++++++++++++++++--------
 fs/notify/notification.c             | 38 ++++++++++++++++++++++++++------
 include/linux/fsnotify_backend.h     |  7 ++++++
 5 files changed, 73 insertions(+), 16 deletions(-)

-- 
2.9.3