linux-kernel - [PATCH 1/5] notify: Call mutex_destroy() before freeing mutex memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170324213638.9114-2-jsorensen@fb.com>
Date:   Fri, 24 Mar 2017 17:36:34 -0400
From:   Jes Sorensen <jes.sorensen@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     john@...nmccutchan.com, rlove@...ve.org, eparis@...isplace.org,
        josef@...icpanda.com, kernel-team@...com,
        Jes Sorensen <jsorensen@...com>
Subject: [PATCH 1/5] notify: Call mutex_destroy() before freeing mutex memory

The conversion of notify from using a spinlock to a mutex missed
adding the call mutex_destroy().

Fixes: 986ab09 ("fsnotify: use a mutex instead of a spinlock to protect a groups mark list")
Signed-off-by: Jes Sorensen <jsorensen@...com>
Reviewed-by: Josef Bacik <jbacik@...com>
---
 fs/notify/group.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/notify/group.c b/fs/notify/group.c
index fbe3cbe..d231be3 100644
--- a/fs/notify/group.c
+++ b/fs/notify/group.c
@@ -36,6 +36,7 @@ static void fsnotify_final_destroy_group(struct fsnotify_group *group)
 	if (group->ops->free_group_priv)
 		group->ops->free_group_priv(group);
 
+	mutex_destroy(&group->mark_mutex);
 	kfree(group);
 }
 
-- 
2.9.3