lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 24 Mar 2017 07:54:41 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Grant Grundler <grundler@...omium.org>
Cc:     Clemens Ladisch <clemens@...isch.de>,
        Matthias Kaehlcke <mka@...omium.org>,
        Arnd Bergmann <arnd@...db.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common()
 unsigned

On Thu, Mar 23, 2017 at 02:47:39PM -0700, Grant Grundler wrote:
> On Tue, Mar 14, 2017 at 12:56 AM, Clemens Ladisch <clemens@...isch.de> wrote:
> > Matthias Kaehlcke wrote:
> >> The value passed by the two callers of the function is unsigned anyway.
> >
> > Indeed; and those are just simple wrappers.
> >
> >> Making the parameter unsigned fixes the following warning when building
> >> with clang:
> >>
> >> drivers/char/hpet.c:588:7: error: overflow converting case value to switch condition type (2149083139 to 18446744071563667459) [-Werror,-Wswitch]
> >>         case HPET_INFO:
> >>              ^
> >> include/uapi/linux/hpet.h:18:19: note: expanded from macro 'HPET_INFO'
> >>                         ^
> >> include/uapi/asm-generic/ioctl.h:77:28: note: expanded from macro '_IOR'
> >>                                 ^
> >> include/uapi/asm-generic/ioctl.h:66:2: note: expanded from macro '_IOC'
> >>         (((dir)  << _IOC_DIRSHIFT) | \
> >>
> >> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> >
> > Acked-by: Clemens Ladisch <clemens@...isch.de>
> 
> Any other feedback on this patch?
> Or has this already been added to someone's "for-linus" branch?
> 
> just looking for update on patch status.

This is already in my -next branch, to go into 4.12-rc1.  Should it get
into 4.11-final instead?

thanks,

greg k-h

Powered by blists - more mailing lists