linux-kernel - Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+aCy1FPdRnihN-Yb7K0t=Ne_-aK+4_u98ydQ65sd7OK_Nhj5g@mail.gmail.com>
Date:   Fri, 24 Mar 2017 15:44:02 +0530
From:   Pranay Srivastava <pranjas@...il.com>
To:     Greg KH <greg@...ah.com>
Cc:     William Hubbs <w.d.hubbs@...il.com>,
        Christopher Brannon <chris@...-brannons.com>, kirk@...sers.ca,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        speakup@...ux-speakup.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as
 per required context

On Fri, Mar 24, 2017 at 2:13 PM, Greg KH <greg@...ah.com> wrote:
> On Fri, Mar 24, 2017 at 02:07:11PM +0530, Pranay Kr. Srivastava wrote:
>> speakup_allocate used GFP_ATOMIC for allocations
>> even while during initialization due to it's use
>> in notifier call.
>
> Is that a problem?

No that's the way it should be. I was just trying to say that allocation
should be context based[?]. If we can be lenient then that's better[?]

>
>> Pass GFP_ flags as well to speakup_allocate depending
>> on the context it is called in.
>
> At init, we should be fine to use GFP_ATOMIC, so is this change really
> needed?
>
> thanks,
>
> greg k-h



-- 
        ---P.K.S