lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Mar 2017 11:57:00 +0100 From: Ingo Molnar <mingo@...nel.org> To: Dmitry Vyukov <dvyukov@...gle.com> Cc: Mark Rutland <mark.rutland@....com>, Peter Zijlstra <peterz@...radead.org>, Andrey Ryabinin <aryabinin@...tuozzo.com>, Ingo Molnar <mingo@...hat.com>, Will Deacon <will.deacon@....com>, Andrew Morton <akpm@...ux-foundation.org>, kasan-dev <kasan-dev@...glegroups.com>, "linux-mm@...ck.org" <linux-mm@...ck.org>, "x86@...nel.org" <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Linus Torvalds <torvalds@...ux-foundation.org>, Thomas Gleixner <tglx@...utronix.de>, "H. Peter Anvin" <hpa@...or.com> Subject: Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations * Dmitry Vyukov <dvyukov@...gle.com> wrote: > > Are just utterly disgusting that turn perfectly readable code into an > > unreadable, unmaintainable mess. > > > > You need to find some better, cleaner solution please, or convince me that no > > such solution is possible. NAK for the time being. > > Well, I can just write all functions as is. Does it better confirm to kernel > style? I think writing the prototypes out as-is, properly organized, beats any of these macro based solutions. > [...] I've just looked at the x86 atomic.h and it uses macros for similar > purpose (ATOMIC_OP/ATOMIC_FETCH_OP), so I thought that must be idiomatic kernel > style... Mind fixing those too while at it? And please squash any bug fixes and re-send a clean series against latest upstream or so. Thanks, Ingo
Powered by blists - more mailing lists