linux-kernel - Re: [RFC PATCH] x86_64/mm/boot: Fix kernel_ident_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170324120458.nw3fwpmdptjtj5qb@node.shutemov.name>
Date:   Fri, 24 Mar 2017 15:04:58 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Xunlei Pang <xlpang@...hat.com>, Ingo Molnar <mingo@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kexec@...ts.infradead.org,
        x86@...nel.org,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [RFC PATCH] x86_64/mm/boot: Fix kernel_ident_mapping_init()
 failure for kexec

On Mon, Mar 20, 2017 at 02:11:31PM +0800, Xunlei Pang wrote:
> I found that the kdump is broken on linux-4.11.0-rc2+

That's actually tip tree or linux-next. The problematic change is not in
Linus' tree.

> , probably
> due to the 5level-paging feature that "#define p4d_present(p4d) 1",
> as a result in ident_p4d_init(), it will go into ident_pud_init()
> directly without allocating the new pud.
> 
> Looks like this patch can make it work again.

Okay, that's bisectability issue. Uncovered by splitting my patchset into
parts.

Could you check if applying "Part 2" of 5-level paging changes[1] would
help you?

Making the code work with both <asm-generic/5level-fixup.h> and
<asm-generic/pgtable-nop4d.h> would make it even uglier. Not sure if it
makes sense to address it on its own if second part fixes the situation.

[1] http://lkml.kernel.org/r/20170317185515.8636-1-kirill.shutemov@linux.intel.com

-- 
 Kirill A. Shutemov