linux-kernel - Re: [PATCH V4 3/4] dt-bindings: serial: add a new compatible string for SC9860

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170324023657.2iyh22lr52rme5bu@rob-hp-laptop>
Date:   Thu, 23 Mar 2017 21:36:57 -0500
From:   Rob Herring <robh@...nel.org>
To:     Chunyan Zhang <chunyan.zhang@...eadtrum.com>
Cc:     mark.rutland@....com, gregkh@...uxfoundation.org,
        catalin.marinas@....com, will.deacon@....com, arnd@...db.de,
        mathieu.poirier@...aro.org, orson.zhai@...eadtrum.com,
        sudeep.holla@....com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        zhang.lyra@...il.com
Subject: Re: [PATCH V4 3/4] dt-bindings: serial: add a new compatible string
 for SC9860

On Fri, Mar 17, 2017 at 01:51:37PM +0800, Chunyan Zhang wrote:
> SC9860 use the same serial device which SC9836 uses, so added a new
> compatible string to support SC9860 as well, also added an example
> of how to describe this serial device in DT.
> 
> Signed-off-by: Chunyan Zhang <chunyan.zhang@...eadtrum.com>
> ---
>  Documentation/devicetree/bindings/serial/sprd-uart.txt | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> index 2aff0f2..1db5d6f 100644
> --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt
> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> @@ -1,7 +1,19 @@
>  * Spreadtrum serial UART
>  
>  Required properties:
> -- compatible: must be "sprd,sc9836-uart"
> +- compatible: must be one of:
> +  * "sprd,sc9836-uart"
> +  * "sprd,sc9860-uart", "sprd,sc9836-uart"
> +
>  - reg: offset and length of the register set for the device
>  - interrupts: exactly one interrupt specifier
>  - clocks: phandles to input clocks.
> +
> +Example:
> +	uart0: serial@...000 {

serial@0

With that,

Acked-by: Rob Herring <robh@...nel.org>


> +		compatible = "sprd,sc9860-uart",
> +			     "sprd,sc9836-uart";
> +		reg = <0x000000 0x100>;
> +		interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&ext_26m>;
> +	};
> -- 
> 2.7.4
>