lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Mar 2017 18:42:49 +0000 From: Ard Biesheuvel <ard.biesheuvel@...aro.org> To: Jan Kiszka <jan.kiszka@...mens.com> Cc: Matt Fleming <matt@...eblueprint.co.uk>, "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Andy Shevchenko <andy.shevchenko@...il.com>, "Bryan O'Donoghue" <pure.logic@...us-software.ie>, Hock Leong Kweh <hock.leong.kweh@...el.com>, Borislav Petkov <bp@...en8.de>, Sascha Weisenberger <sascha.weisenberger@...mens.com> Subject: Re: [PATCH v2 4/7] efi/capsule: Adjust return type of efi_capsule_setup_info On 24 March 2017 at 17:34, Jan Kiszka <jan.kiszka@...mens.com> wrote: > We actually expect int at the caller and never return any size > information. > > Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@...aro.org> > --- > drivers/firmware/efi/capsule-loader.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/efi/capsule-loader.c b/drivers/firmware/efi/capsule-loader.c > index 3fb91e1..37d3f6e 100644 > --- a/drivers/firmware/efi/capsule-loader.c > +++ b/drivers/firmware/efi/capsule-loader.c > @@ -53,8 +53,8 @@ static void efi_free_all_buff_pages(struct capsule_info *cap_info) > * @kbuff: a mapped first page buffer pointer > * @hdr_bytes: the total received number of bytes for efi header > **/ > -static ssize_t efi_capsule_setup_info(struct capsule_info *cap_info, > - void *kbuff, size_t hdr_bytes) > +static int efi_capsule_setup_info(struct capsule_info *cap_info, > + void *kbuff, size_t hdr_bytes) > { > efi_capsule_header_t *cap_hdr; > size_t pages_needed; > -- > 2.10.2 >
Powered by blists - more mailing lists