linux-kernel - Re: [PATCH v4] statx: optimize copy of struct statx to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170324210826.GB4986@gmail.com>
Date:   Fri, 24 Mar 2017 14:08:26 -0700
From:   Eric Biggers <ebiggers3@...il.com>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-fsdevel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
        linux-kernel@...r.kernel.org, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH v4] statx: optimize copy of struct statx to userspace

On Thu, Mar 16, 2017 at 11:41:41AM +0000, David Howells wrote:
> Eric Biggers <ebiggers3@...il.com> wrote:
> 
> > stat() instead initializes its struct on the stack and copies it to
> > userspace with a single call to copy_to_user().  This turns out to be
> > much faster, and changing statx to do this makes it almost as fast as
> > stat:
> 
> I wonder if we actually need to copy __spare2 at the end.  We could define any
> future values added in there to be unset/undefined if the respective bits are
> not set.
> 
> I would prefer it to be cleaner, however, and clear the unused space.
> 
> Another thought is does it make sense to rearrange struct kstat to mirror
> the first part of struct statx so that this can be memcpy'd?
> 
> David

Not clearing __spare2 would effectively turn every new bit into specifying an
"extension of the buffer", and there would be no way for the kernel to provide a
"fabricated" value for any new field.  I don't think it's the right choice.

Also I don't think it makes sense to rearrange struct kstat to match struct
statx, because that would bring details of the syscall ABI down into places it
shouldn't be.  Also, struct kstat is used to hold information for both stat()
and statx().  It doesn't make sense to optimize statx() at the expense of stat()
yet because almost everything will still be using stat() in the near-term.

- Eric