linux-kernel - Re: [PATCH v2] UBI: add debugfs file for tracking PEB state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201703252344.iKNfSlbB%fengguang.wu@intel.com>
Date:   Sat, 25 Mar 2017 23:23:25 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Zach Brown <zach.brown@...com>
Cc:     kbuild-all@...org, dwmw2@...radead.org,
        computersforpeace@...il.com, boris.brezillon@...e-electrons.com,
        marek.vasut@...il.com, richard@....at, cyrille.pitchen@...el.com,
        dedekind1@...il.com, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] UBI: add debugfs file for tracking PEB state

Hi Ben,

[auto build test WARNING on v4.9-rc8]
[also build test WARNING on next-20170324]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Zach-Brown/UBI-add-debugfs-file-for-tracking-PEB-state/20170325-205127
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/mtd/ubi/debug.c: In function 'eraseblk_count_seq_show':
>> drivers/mtd/ubi/debug.c:465:19: warning: comparison of constant '0' with boolean expression is always false [-Wbool-compare]
     if (!erase_count < 0)
                      ^
>> drivers/mtd/ubi/debug.c:465:19: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]

vim +/0 +465 drivers/mtd/ubi/debug.c

   449				 "physical_block_number\terase_count\tblock_status\tread_status\n");
   450			return 0;
   451		}
   452	
   453		err = ubi_io_is_bad(ubi, *block_number);
   454		if (err)
   455			return err;
   456	
   457		spin_lock(&ubi->wl_lock);
   458	
   459		wl = ubi->lookuptbl[*block_number];
   460		if (wl)
   461			erase_count = wl->ec;
   462	
   463		spin_unlock(&ubi->wl_lock);
   464	
 > 465		if (!erase_count < 0)
   466			return 0;
   467	
   468		seq_printf(s, "%-22d\t%-11d\n", *block_number, erase_count);
   469	
   470		return 0;
   471	}
   472	
   473	static const struct seq_operations eraseblk_count_seq_ops = {

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (38054 bytes)