linux-kernel - Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87poh523r3.fsf@linux.intel.com>
Date:   Sat, 25 Mar 2017 09:51:28 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Shuah Khan <shuahkh@....samsung.com>, gregkh@...uxfoundation.org,
        kgene@...nel.org, krzk@...nel.org, javier@....samsung.com
Cc:     Shuah Khan <shuahkh@....samsung.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels


Hi,

Shuah Khan <shuahkh@....samsung.com> writes:
> This patch series consists of two fixes and changes to goto labels

we *NEVER* put cleanups and fixes together.

> to use meaningful names.
>
> While working on goto label changes, I noticed  put_sync calls without
> successful get_sync in error legs.  The first two patches are the fixes
> and the rest of the patches are goto label changes.

so, you mean to say that you're adding regressions because you *THOUGHT*
there was a bug there, right? Read the docs ;-)

-- 
balbi