lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 Mar 2017 15:54:09 +0100 From: Russell King - ARM Linux <linux@...linux.org.uk> To: Leo Yan <leo.yan@...aro.org> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, Alessandro Zummo <a.zummo@...ertech.it>, Alexandre Belloni <alexandre.belloni@...e-electrons.com>, Linus Walleij <linus.walleij@...aro.org>, Baptiste Reynal <b.reynal@...tualopensystems.com>, Alex Williamson <alex.williamson@...hat.com>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com, linux-arm-kernel@...ts.infradead.org, kvm@...r.kernel.org, alsa-devel@...a-project.org Subject: Re: [PATCH 5/5] ALSA: AACI: Convert to use devm_ioremap_resource() On Sun, Mar 26, 2017 at 10:41:54PM +0800, Leo Yan wrote: > Convert to use devm_ioremap_resource() in probe function, otherwise it's > missed to unremap this region if probe failed or rmmod module. Again, wrong - just because there's nothing in the cleanup paths does not mean it doesn't clean up. static void aaci_free_card(struct snd_card *card) { struct aaci *aaci = card->private_data; iounmap(aaci->base); } This unmaps the mapping you claim it fails to do so. So, your patch actually _creates_ bugs that were not there before. NAK. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Powered by blists - more mailing lists