linux-kernel - Re: [RFC PATCH kernel] gcc-goto.sh: Allow to pass with CONFIG_DEBUG_INFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78cec56d-abc1-f1aa-8810-78f3341bb9d4@ozlabs.ru>
Date:   Mon, 27 Mar 2017 13:33:02 +1100
From:   Alexey Kardashevskiy <aik@...abs.ru>
To:     Jason Baron <jbaron@...hat.com>
Cc:     Michael Ellerman <mpe@...erman.id.au>,
        linux-kernel@...r.kernel.org, Rabin Vincent <rabin@....in>,
        Jiang Liu <liuj97@...il.com>,
        Russell King <rmk+kernel@....linux.org.uk>,
        Catalin Marinas <catalin.marinas@....com>,
        Michal Marek <mmarek@...e.cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [RFC PATCH kernel] gcc-goto.sh: Allow to pass with
 CONFIG_DEBUG_INFO_SPLIT=y

On 15/03/17 13:27, Alexey Kardashevskiy wrote:
> On 14/03/17 13:54, Alexey Kardashevskiy wrote:
>> On 03/03/17 11:51, Alexey Kardashevskiy wrote:
>>> With just CONFIG_DEBUG_INFO=y, the makefile adds "-g" to
>>> KBUILD_CFLAGS/KBUILD_AFLAGS and the test passes.
>>>
>>> However, if CONFIG_DEBUG_INFO_SPLIT is also enabled, the makefile
>>> adds "-gsplit-dwarf" instead which makes the test fail with $?==1
>>> because of objcopy trying to split the debug info:
>>>
>>> objcopy: Warning: '/dev/null' is not an ordinary file
>>>
>>> This changes the output to $(mktemp) which fixes the problem.
>>>
>>> I am pretty sure there better ways, this is just to demonstrate the bug.
>>>
>>> gcc 5.4.1, ppc64le (does not really matter).
>>>
>>> Cc: Jason Baron <jbaron@...hat.com>
>>
>>
>> Ping?
> 
> I am adding more folks as Jason's mail server rejects mails with "Recipient
> address rejected: Access denied ".


Anyone, ping?


> 
> 
>>
>>
>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@...abs.ru>
>>> ---
>>>  scripts/gcc-goto.sh | 5 ++++-
>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/gcc-goto.sh b/scripts/gcc-goto.sh
>>> index c9469d34ecc6..ab21216ab68d 100755
>>> --- a/scripts/gcc-goto.sh
>>> +++ b/scripts/gcc-goto.sh
>>> @@ -2,7 +2,8 @@
>>>  # Test for gcc 'asm goto' support
>>>  # Copyright (C) 2010, Jason Baron <jbaron@...hat.com>
>>>  
>>> -cat << "END" | $@ -x c - -c -o /dev/null >/dev/null 2>&1 && echo "y"
>>> +TMPOUT=$(mktemp)
>>> +cat << "END" | $@ -x c - -c -o $TMPOUT >/dev/null 2>&1 && echo "y"
>>>  int main(void)
>>>  {
>>>  #if defined(__arm__) || defined(__aarch64__)
>>> @@ -19,3 +20,5 @@ entry:
>>>  	return 0;
>>>  }
>>>  END
>>> +
>>> +rm $TMPOUT 2>/dev/null 2>&1
>>>
>>
>>
> 
> 


-- 
Alexey