linux-kernel - Re: [PATCH v2 1/2] net: phy: Fix PHY AN done state machine for interrupt driven PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <587458e9-7287-2036-50a9-00c009a7f02c@ti.com>
Date:   Mon, 27 Mar 2017 14:50:30 +0300
From:   Roger Quadros <rogerq@...com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        <f.fainelli@...il.com>
CC:     <andrew@...n.ch>, <davem@...emloft.net>, <kyle.roeschley@...com>,
        <nsekhar@...com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        "stable # v4 . 9+" <stable@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] net: phy: Fix PHY AN done state machine for
 interrupt driven PHYs

On 23/03/17 11:52, Sergei Shtylyov wrote:
> Hello!
> 
> On 3/22/2017 2:02 PM, Roger Quadros wrote:
> 
>> he ethernet link on an interrupt driven PHY was not coming up if the
> 
>    s/he/The/?
> 
>> ethernet cable was plugged before the ethernet interface was brought up.
> 
>    Also, my spell checker trips on "ethernet", perhaps should be capitalized?

Thanks. I'll fix both issues.

> 
>> The PHY state machine seems to be stuck from RUNNING to AN state
>> with no new interrupts from the PHY. So it doesn't know when the
>> PHY Auto-negotiation has been completed and doesn't transition to RUNNING
>> state with ANEG done thus netif_carrier_on() is never called.
>>
>> NOTE: genphy_config_aneg() will not restart PHY Auto-negotiation of
>> advertisement parameters didn't change.
>>
>> Fix this by scheduling the PHY state machine in phy_start_aneg().
>>
>> Fixes: 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.")
>> Cc: stable <stable@...r.kernel.org> # v4.9+
>> Signed-off-by: Roger Quadros <rogerq@...com>
> [...]
> 
> MBR, Sergei
> 

cheers,
-roger