linux-kernel - RE: [PATCH] netvsc: fix unititialized return value in variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BLUPR03MB14128BF9E77DB2E22206F99ACA330@BLUPR03MB1412.namprd03.prod.outlook.com>
Date:   Mon, 27 Mar 2017 00:52:38 +0000
From:   Haiyang Zhang <haiyangz@...rosoft.com>
To:     Colin King <colin.king@...onical.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] netvsc: fix unititialized return value in variable ret



> -----Original Message-----
> From: Colin King [mailto:colin.king@...onical.com]
> Sent: Saturday, March 25, 2017 10:17 AM
> To: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> <haiyangz@...rosoft.com>; Stephen Hemminger <sthemmin@...rosoft.com>;
> devel@...uxdriverproject.org; netdev@...r.kernel.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] netvsc: fix unititialized return value in variable ret
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> It is possible for an uninitialized value of ret to be returned
> so fix this by initializing ret to zero.
> 
> Detected by CoverityScan, CID#1420762 ("Uninitialized scalar variable")
> 
> Fixes: 163891d7d429 ("netvsc: handle offline mtu and channel change")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/hyperv/netvsc_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/hyperv/netvsc_drv.c
> b/drivers/net/hyperv/netvsc_drv.c
> index eb7ae79d47bb..f830bbbd8ad4 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -855,7 +855,7 @@ static int netvsc_change_mtu(struct net_device *ndev,
> int mtu)
>  	struct hv_device *hdev = ndevctx->device_ctx;
>  	struct netvsc_device_info device_info;
>  	bool was_running;
> -	int ret;
> +	int ret = 0;

This was just fix by commit: 386f57622cc3bbb39b9c00fc8762bc9ab28e0f8d

Thanks.