linux-kernel - Re: [PATCH v10 01/11] h8300: put bitsperlong.h in uapi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNASeY8-74c_7wcgVdw5BwCgJGO48YsTMzc06rAFRRqAyPw@mail.gmail.com>
Date:   Mon, 27 Mar 2017 14:31:21 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Michal Marek <mmarek@...e.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        "David S. Miller" <davem@...emloft.net>,
        Russell King <linux@...linux.org.uk>, bp@...en8.de,
        slash.tmp@...e.fr, Daniel Vetter <daniel.vetter@...ll.ch>,
        rmk+kernel@...linux.org.uk, msalter@...hat.com, jengelh@...i.de,
        hch@...radead.org, Tobias Klauser <tklauser@...tanz.ch>,
        mpe@...erman.id.au, Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Dmitry V. Levin" <ldv@...linux.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH v10 01/11] h8300: put bitsperlong.h in uapi

Hi Nicolas,


2017-03-14 21:54 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@...nd.com>:
> This header file is exported, thus move it to uapi.
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>



> -#endif /* __ASM_H8300_BITS_PER_LONG */
> diff --git a/arch/h8300/include/uapi/asm/bitsperlong.h b/arch/h8300/include/uapi/asm/bitsperlong.h
> new file mode 100644
> index 000000000000..e56cf72369b6
> --- /dev/null
> +++ b/arch/h8300/include/uapi/asm/bitsperlong.h
> @@ -0,0 +1,14 @@
> +#ifndef _UAPI_ASM_H8300_BITS_PER_LONG
> +#define _UAPI_ASM_H8300_BITS_PER_LONG


Just a minor comment.

The include guard was originally __ASM_H8300_BITS_PER_LONG.
This will change it into _ASM_H8300_BITS_PER_LONG
(after _UAPI is stripped by headers_install.sh)

I just thought _UAPI__ASM_H8300_BITS_PER_LONG might be even safer,
but I know I am nit-picking.  I can apply this as-is.
I leave it to you.


-- 
Best Regards
Masahiro Yamada