linux-kernel - Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Mar 2017 15:15:30 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:     Claudiu Beznea <claudiu.beznea@...rochip.com>,
        thierry.reding@...il.com, robh+dt@...nel.org, pawel.moll@....com,
        mark.rutland@....com, ijc+devicetree@...lion.org.uk,
        galak@...eaurora.org, linux-pwm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, nicolas.ferre@...rochip.com,
        cristian.birsan@...rochip.com, andrei.pistirica@...rochip.com,
        tudor.ambarus@...rochip.com, eugen.hristev@...rochip.com
Subject: Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM

On 27/03/2017 at 15:02:37 +0200, Boris Brezillon wrote:
> Hi Claudiu,
> 
> On Wed, 22 Mar 2017 15:29:34 +0200
> Claudiu Beznea <claudiu.beznea@...rochip.com> wrote:
> 
> >  static const struct platform_device_id atmel_pwm_devtypes[] = {
> >  	{
> >  		.name = "at91sam9rl-pwm",
> > -		.driver_data = (kernel_ulong_t)&atmel_pwm_data_v1,
> > +		.driver_data = (kernel_ulong_t)&atmel_pwm_regs_v1,
> >  	}, {
> >  		.name = "sama5d3-pwm",
> > -		.driver_data = (kernel_ulong_t)&atmel_pwm_data_v2,
> > +		.driver_data = (kernel_ulong_t)&atmel_pwm_regs_v2,
> >  	}, {
> >  		/* sentinel */
> >  	},
> 
> Unrelated to this series, but can you prepare a patch to get rid of
> this platform id table (AT91 platforms have completely switched to DT
> for quite some time now).
> 

Please, don't until AVR32 is gone.

> You can also get rid of the "if (pdev->dev.of_node)" condition in
> atmel_pwm_probe() since it's guaranteed to be true, otherwise the
> ->probe() method wouldn't be called.
> 
> Thanks,
> 
> Boris

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com