lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Mar 2017 14:18:19 +0100 From: Juri Lelli <juri.lelli@....com> To: linux-kernel@...r.kernel.org Cc: linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, peterz@...radead.org, vincent.guittot@...aro.org, robh+dt@...nel.org, mark.rutland@....com, linux@....linux.org.uk, sudeep.holla@....com, lorenzo.pieralisi@....com, catalin.marinas@....com, will.deacon@....com, morten.rasmussen@....com, dietmar.eggemann@....com, juri.lelli@....com, broonie@...nel.org, gregkh@...uxfoundation.org Subject: [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity parse_cpu_capacity() has to return 0 on failure, but it currently returns 1 instead if raw_capacity kcalloc failed. Fix it by removing the negation of the return value. Cc: Russell King <linux@....linux.org.uk> Reported-by: Morten Rasmussen <morten.rasmussen@....com> Fixes: 06073ee26775 ('ARM: 8621/3: parse cpu capacity-dmips-mhz from DT') Signed-off-by: Juri Lelli <juri.lelli@....com> --- arch/arm/kernel/topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c index f8a3ab82e77f..4e4af809606a 100644 --- a/arch/arm/kernel/topology.c +++ b/arch/arm/kernel/topology.c @@ -166,7 +166,7 @@ static int __init parse_cpu_capacity(struct device_node *cpu_node, int cpu) if (!raw_capacity) { pr_err("cpu_capacity: failed to allocate memory for raw capacities\n"); cap_parsing_failed = true; - return !ret; + return ret; } } capacity_scale = max(cpu_capacity, capacity_scale); -- 2.10.0
Powered by blists - more mailing lists