linux-kernel - Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Mar 2017 07:44:26 -0600
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Felipe Balbi <balbi@...nel.org>, gregkh@...uxfoundation.org,
        kgene@...nel.org, krzk@...nel.org, javier@....samsung.com
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-omap@...r.kernel.org,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels

On 03/25/2017 01:51 AM, Felipe Balbi wrote:
> 
> Hi,
> 
> Shuah Khan <shuahkh@....samsung.com> writes:
>> This patch series consists of two fixes and changes to goto labels
> 
> we *NEVER* put cleanups and fixes together.
> 
>> to use meaningful names.
>>
>> While working on goto label changes, I noticed  put_sync calls without
>> successful get_sync in error legs.  The first two patches are the fixes
>> and the rest of the patches are goto label changes.
> 
> so, you mean to say that you're adding regressions because you *THOUGHT*
> there was a bug there, right? Read the docs ;-)
> 

Sorry for the noise. Thanks for pointing this out.

-- Shuah