linux-kernel - Re: [PATCH 0/4] sched: Minor cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170327135805.t3pnkomktsm4j2vw@hirez.programming.kicks-ass.net>
Date:   Mon, 27 Mar 2017 15:58:05 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Ingo Molnar <mingo@...hat.com>, linaro-kernel@...ts.linaro.org,
        linux-kernel@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH 0/4] sched: Minor cleanups

On Thu, Mar 23, 2017 at 05:05:55PM +0530, Viresh Kumar wrote:
> Hi,
> 
> Here are few minor cleanups for the sched core. The first three tries to
> avoid reinitializing memory which is already set to zero and the last
> one drops an unused statement.
> 

I'm OK with the kzalloc/memset thing, but I'd prefer to keep all those
other bits.

Yes they're superfluous, but this is init code, so nobody cares about
performance and having those things explitic makes it easier to read.

As to the very latest patch, that's there so that if/when we extend that
array we can simply continue. Also its more symmetric/consistent. Any
half sane DCE pass should get rid of it anyway, as the result is unused.