linux-kernel - Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Mar 2017 16:12:58 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Willy Tarreau <willy@...roxy.com>
Subject: Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder

On Fri, Mar 24, 2017 at 4:19 PM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> Hi Andy,
>
> On Fri, Mar 24, 2017 at 3:29 PM, Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
>> On Fri, 2017-03-24 at 15:19 +0100, Geert Uytterhoeven wrote:
>>> On Fri, Mar 24, 2017 at 3:06 PM, Andy Shevchenko
>>> <andriy.shevchenko@...ux.intel.com> wrote:
>>> > It looks like panel.c belongs to auxdisplay subsystem.
>>> >
>>> > Move it to drivers/auxdisplay folder.
>>> > No functional changes intended.
>>>
>>> I didn't move it to drivers/auxdisplay/ because it not only provides
>>> auxdisplay functionality, but also keypad functionality.
>>
>> Yes, I have noticed this. But keypad functionality is optional while
>> panel is main one. I think you would agree on this.
>
> I don't care that much, though. Willy?

I think moving all of it to drivers/auxdisplay as it is today, and doing
any further cleanup on the driver over there is a good idea.

On a related note, how about moving arm-charlcd there as well,
and finding a new place for the various ALS drivers?

        Arnd