linux-kernel - Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170327142443.zkaiieehqeirk4pi@earth>
Date:   Mon, 27 Mar 2017 16:24:43 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for
 request_threaded_irq

Hi,

On Sun, Mar 26, 2017 at 08:34:23PM -0700, Tony Lindgren wrote:
> There's a funny typo where IRQ_NONE is used instead of IRQF_TRIGGER_NONE
> for request_threaded_irq(). Let's fix it before it gets copied elsewhere.
> 
> Fixes: dd3bf50b35e3 ("rtc: cpcap: new rtc driver")
> Cc: Sebastian Reichel <sre@...nel.org>
> Signed-off-by: Tony Lindgren <tony@...mide.com>

Reviewed-By: Sebastian Reichel <sre@...nel.org>

-- Sebastian

> ---
>  drivers/rtc/rtc-cpcap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
> --- a/drivers/rtc/rtc-cpcap.c
> +++ b/drivers/rtc/rtc-cpcap.c
> @@ -275,7 +275,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
>  
>  	rtc->alarm_irq = platform_get_irq(pdev, 0);
>  	err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
> -					cpcap_rtc_alarm_irq, IRQ_NONE,
> +					cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE,
>  					"rtc_alarm", rtc);
>  	if (err) {
>  		dev_err(dev, "Could not request alarm irq: %d\n", err);
> @@ -291,7 +291,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
>  	 */
>  	rtc->update_irq = platform_get_irq(pdev, 1);
>  	err = devm_request_threaded_irq(dev, rtc->update_irq, NULL,
> -					cpcap_rtc_update_irq, IRQ_NONE,
> +					cpcap_rtc_update_irq, IRQF_TRIGGER_NONE,
>  					"rtc_1hz", rtc);
>  	if (err) {
>  		dev_err(dev, "Could not request update irq: %d\n", err);
> -- 
> 2.12.1

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)