linux-kernel - Re: kvm: use-after-free in srcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4771c114-1d85-0dac-b945-7f91cf7ac948@redhat.com>
Date:   Mon, 27 Mar 2017 17:02:56 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Dmitry Vyukov <dvyukov@...gle.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        KVM list <kvm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Steve Rutherford <srutherford@...gle.com>,
        Wanpeng Li <kernellwp@...il.com>,
        Haozhong Zhang <haozhong.zhang@...el.com>,
        James Mattson <jmattson@...gle.com>,
        David Hildenbrand <david@...hat.com>,
        Cornelia Huck <cornelia.huck@...ibm.com>,
        xiaoguangrong.eric@...il.com,
        Paul McKenney <paulmck@...ux.vnet.ibm.com>
Cc:     syzkaller <syzkaller@...glegroups.com>
Subject: Re: kvm: use-after-free in srcu_reschedule



On 27/03/2017 16:46, Dmitry Vyukov wrote:
> 
> Paul McKenney writes:
> 
> ===
> Hmmm...  I am not seeing a call to cleanup_srcu_struct() for the
> ->track_srcu field of the kvm_page_track_notifier_head structure.
> Or is this structure immortal, so that it is never cleaned up?
> Or am I just blind this morning?
> 
> In any case, freeing the kvm_page_track_notifier_head structure
> without first invoking cleanup_srcu_struct() on its ->track_srcu
> srcu_struct field could easily result in a use-after-free bug.
> ===
> 
> I also don't see cleanup of page track srcu.

Thanks, will take a look and fix.

Paolo